Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: import typescript types from external file #39

Merged
merged 3 commits into from
Apr 18, 2023

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Apr 17, 2023

This extracts the typescript file so we generate to one file and afterwards we aim to import it in our co-located files.

Currently this already successfully generates __generated__/baseGraphQLSP.ts however, I am not succeeding in making GraphQL Code Generator import it after the fact 😅

Resolves #13

@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2023

🦋 Changeset detected

Latest commit: 4d9ee2b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@0no-co/graphqlsp Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoviDeCroock JoviDeCroock marked this pull request as ready for review April 18, 2023 15:22
@JoviDeCroock JoviDeCroock merged commit d81a4b3 into main Apr 18, 2023
@JoviDeCroock JoviDeCroock deleted the import-types-from-global branch April 18, 2023 15:30
@github-actions github-actions bot mentioned this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hoist the typescript types
2 participants